Allow references to casks when running upgrade and outdated #7927

whoiswillma · 2020-07-06T23:07:47Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

Tests were not written because I think the same conditions hold for this PR as for this other PR

brew upgrade upgrades both formulae and casks.

brew outdated was tricky to integrate because of the --json option. It makes sense for brew outdated with no arguments to print all outdated formulae and casks, which implies brew outdated --json should print the json for formulae and casks. However, I did not want to change the behavior of brew outdated --json lest any scripts that depend on it break. I settled on the following compromise:

brew outdated --json prints json information for only formulae, which makes it equivalent to brew outdated --json --formula-only
brew outdated --json --cask-only prints json information for only casks.

Another possibility is a v2 json API for brew outdated, but I haven't seen any demand for such feature

A small script to install an outdated version of atom and youtube-dl (cask and formula respectively). Useful for testing

echo "Uninstalling atom, youtube-dl"
brew uninstall atom youtube-dl

LR=$pwd

echo "Installing atom 1.47.0"
cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask/
git checkout a023e3d0754c0d8a5647891328f5b64caa5512ba -- Casks/atom.rb
brew cask install atom
git restore --staged Casks/atom.rb
git restore Casks/atom.rb

echo "Installing youtube-dl 2020.05.08"
cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/
git checkout 877666acfa7af926b0623dcdc7839e182c8e95d4 -- Formula/youtube-dl.rb
brew install youtube-dl
git restore --staged Formula/youtube-dl.rb
git restore Formula/youtube-dl.rb

cd $LR

MikeMcQuaid · 2020-07-07T09:11:50Z

brew upgrade upgrades both formulae and casks.

@homebrew/cask @vitorgalvao any objections/thoughts on this?

miccal · 2020-07-07T13:39:18Z

How would this work the the unique options for brew upgrade and brew cask upgrade?

For brew upgrade:

For brew cask upgrade:

MikeMcQuaid · 2020-07-07T13:52:05Z

@miccal It would accept arguments for both and only pass on those relevant to the given command.

whoiswillma · 2020-07-07T13:52:36Z

The relevant flags passed to brew upgrade are forwarded to brew cask upgrade, and --greedy has been added as a flag to brew upgrade for the sole purpose of interacting with brew cask upgrade. No errors are shown when a brew upgrade-only switch is used (although I think there is a usability argument for this).

I guess Mike and I were writing the same comment at the same time, oops :/

miccal · 2020-07-07T13:54:51Z

Thank you for the explanation @whoiswillma and @MikeMcQuaid -- I think it would make sense to unify the upgrade commands for brew and brew cask.

vitorgalvao · 2020-07-07T13:56:48Z

any objections

None.

MikeMcQuaid

One tweak otherwise looking great!

Library/Homebrew/cmd/outdated.rb

MikeMcQuaid

Almost there! Nice work 👏

Library/Homebrew/cmd/outdated.rb

Library/Homebrew/cmd/upgrade.rb

jonchang · 2020-07-16T07:37:23Z

@whoiswillma can you enable edits for maintainers? This pull request needs to be rebased; I've done it locally but it needs to be on GitHub before this can be merged. Thanks!

whoiswillma · 2020-07-16T13:24:56Z

Seems like GitHub is being a bit finicky with push access on PRs since I'm not the one that made the fork. I think you have direct write access to the fork now. Is that enough?

For consistency with brew --cache

jonchang · 2020-07-16T13:32:40Z

Thanks, looks like that worked.

reitermarkus · 2020-07-16T15:35:40Z

I think for the --json flag we should default to --json=v1 and print both formulae and casks with --json=v2.

reitermarkus · 2020-07-16T15:37:17Z

Maybe also deprecate --json without explicit version.

whoiswillma · 2020-07-16T16:52:32Z

I'll work on those changes

whoiswillma · 2020-07-16T17:05:35Z

For reference, here is an example output of json for outdated formula:

[
  {
    "name":"libgcrypt",
    "installed_versions":[
      "1.8.5"
    ],
    "current_version":"1.8.6",
    "pinned":false,
    "pinned_version":null
  }
]

and outdated casks:

[
  {
    "name":"atom",
    "installed_versions":"1.47.0",
    "current_version":"1.49.0"
  }
]

Given that the schema is slightly different between formulae and casks, I think the json v2 for formulae and casks should be completely separate. Maybe something like:

{
    "casks": ...
    "formulae": ...
}

But I can see the argument for having them be merged: thoughts?

whoiswillma · 2020-07-17T00:40:27Z

Commit history is a bit messed up. I'll work on fixing it tomorrow

Update: Commit history is fixed now.

Library/Homebrew/cmd/outdated.rb

Co-authored-by: Eric Knibbe <enk3@outlook.com>

MikeMcQuaid

Looking good so far, nice work!

Library/Homebrew/cmd/outdated.rb

MikeMcQuaid

Almost there 🎉

Library/Homebrew/cmd/outdated.rb

MikeMcQuaid · 2020-07-27T14:14:23Z

Thanks again @whoiswillma!

miccal · 2020-08-04T13:43:26Z

@whoiswillma and @MikeMcQuaid I have created an issue here that I believe is a consequence of the changes made in this PR.

Thank you.

whoiswillma marked this pull request as draft July 6, 2020 23:24

whoiswillma marked this pull request as ready for review July 7, 2020 15:00

MikeMcQuaid reviewed Jul 8, 2020

View reviewed changes

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

MikeMcQuaid reviewed Jul 9, 2020

View reviewed changes

whoiswillma and others added 9 commits July 16, 2020 23:31

Integrate upgrade with cask

210d22e

upgrade: Move logic to find outdated formulae into upgrade method

ad04284

outdated: Allow references to cask

bdc99eb

outdated: Actually print json information for casks

a3da9fa

outdated: Fail when user supplies formulae and some are outdated

966131f

outdated: Update logic when handling --json to be more explicit

ee0e994

outdated: Rename --formula-only and --cask-only to --formula and --cask

d81296f

For consistency with brew --cache

Fix PR issues

299db98

docs: update manpages

1efb55d

whoiswillma added 2 commits July 17, 2020 08:53

outdated: Implement json v2

8c5140f

outdated: Update documentation about json versions

0385731

EricFromCanada reviewed Jul 20, 2020

View reviewed changes

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

whoiswillma and others added 2 commits July 20, 2020 14:35

outdated: Fix documentation style

b4f8e23

Co-authored-by: Eric Knibbe <enk3@outlook.com>

outdated: Update tests for deprecation warning

fa0f6f4

MikeMcQuaid reviewed Jul 22, 2020

View reviewed changes

outdated: Fix most code review comments

8d4a443

MikeMcQuaid reviewed Jul 27, 2020

View reviewed changes

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

Add todo for --json=v1 deprecation

f8708ae

MikeMcQuaid reviewed Jul 27, 2020

View reviewed changes

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved

outdated: vary deprecated message depending on flag

fa60d99

MikeMcQuaid approved these changes Jul 27, 2020

View reviewed changes

MikeMcQuaid merged commit 2ff56c9 into Homebrew:master Jul 27, 2020

miccal mentioned this pull request Aug 4, 2020

brew upgrade is not respecting HOMEBREW_CASK_OPTS="--no-quarantine" Homebrew/homebrew-cask#87045

Closed

6 tasks

miccal mentioned this pull request Aug 6, 2020

cask/cmd/update: output message consistency #8227

Merged

6 tasks

NReilingh mentioned this pull request Aug 6, 2020

brew upgrade upgrades all casks unexpectedly #8228

Closed

3 tasks

whoiswillma mentioned this pull request Oct 10, 2020

cmd/info: Add support for casks in brew info #8893

Merged

9 tasks

BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020

Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow references to casks when running upgrade and outdated #7927

Allow references to casks when running upgrade and outdated #7927

whoiswillma commented Jul 6, 2020 •

edited

MikeMcQuaid commented Jul 7, 2020

miccal commented Jul 7, 2020 •

edited

MikeMcQuaid commented Jul 7, 2020

whoiswillma commented Jul 7, 2020 •

edited

miccal commented Jul 7, 2020

vitorgalvao commented Jul 7, 2020

MikeMcQuaid left a comment

MikeMcQuaid left a comment •

edited

jonchang commented Jul 16, 2020

whoiswillma commented Jul 16, 2020

jonchang commented Jul 16, 2020

reitermarkus commented Jul 16, 2020

reitermarkus commented Jul 16, 2020

whoiswillma commented Jul 16, 2020

whoiswillma commented Jul 16, 2020 •

edited

whoiswillma commented Jul 17, 2020 •

edited

MikeMcQuaid left a comment

MikeMcQuaid left a comment

MikeMcQuaid commented Jul 27, 2020

miccal commented Aug 4, 2020

Allow references to casks when running upgrade and outdated #7927

Allow references to casks when running upgrade and outdated #7927

Conversation

whoiswillma commented Jul 6, 2020 • edited

MikeMcQuaid commented Jul 7, 2020

miccal commented Jul 7, 2020 • edited

MikeMcQuaid commented Jul 7, 2020

whoiswillma commented Jul 7, 2020 • edited

miccal commented Jul 7, 2020

vitorgalvao commented Jul 7, 2020

MikeMcQuaid left a comment

Choose a reason for hiding this comment

MikeMcQuaid left a comment • edited

Choose a reason for hiding this comment

jonchang commented Jul 16, 2020

whoiswillma commented Jul 16, 2020

jonchang commented Jul 16, 2020

reitermarkus commented Jul 16, 2020

reitermarkus commented Jul 16, 2020

whoiswillma commented Jul 16, 2020

whoiswillma commented Jul 16, 2020 • edited

whoiswillma commented Jul 17, 2020 • edited

MikeMcQuaid left a comment

Choose a reason for hiding this comment

MikeMcQuaid left a comment

Choose a reason for hiding this comment

MikeMcQuaid commented Jul 27, 2020

miccal commented Aug 4, 2020

whoiswillma commented Jul 6, 2020 •

edited

miccal commented Jul 7, 2020 •

edited

whoiswillma commented Jul 7, 2020 •

edited

MikeMcQuaid left a comment •

edited

whoiswillma commented Jul 16, 2020 •

edited

whoiswillma commented Jul 17, 2020 •

edited